Change databaseState in longTermRetention.json to longTermRetentionDatabaseState #2693

trgrie · 2018-03-19T17:05:52Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

This change adds the swagger documentation for the Long Term Retention V2 feature along with examples for each of the APIs.. This includes the following APIs: Get an LTR Backup Get all LTR Backups under a database Get all LTR Backups under a server Get all LTR Backups under a location Delete an LTR Backup Set a database's LTR Policy Get a database's LTR Policy

This update is a response to the few comments that Anu left on the PR. It removes an empty properties entry and updates the retention descriptions to explain that they use an ISO 8601 standard.

Made some slight changes to the entity names to better align with LTR V1 and added some better descriptors to some property descriptions.

The weekOfYear parameter is not in an ISO 8601 format, it is just an integer between 1 and 52. Fixing that accordingly.

Need to remove backupLongTermRetentionPolicies so it doesn't conflict with the new backupLongTermRetentionPolicies.

Need to remove the reference to backupLongTermRetentionPolicies.json in the readme.

Updated the resource ID for longTermRetentionBackups so servers and databases are now longTermRetentionServers and longTermRetentionDatabases, respectively. This better aligns with REST.

LongTermRetentionPolicyGet.json was accidentally deleted in the last commit.

Made some changes to the examples to fix the Travis CI errors.

…ies to BackupLongTermRetentionPolicies

This reverts commit 3b80fa0.

This reverts commit b98cf6c.

…licy to BackupLongTermRetentionPolicy to keep it consistent

…tentionPolicy

AutorestCI · 2018-03-19T17:06:53Z

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

AutorestCI · 2018-03-19T17:08:35Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#1950

AutorestCI · 2018-03-19T17:11:17Z

Automation for azure-libraries-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-libraries-for-java#292

dsgouda · 2018-03-19T17:12:00Z

...ication/sql/resource-manager/Microsoft.Sql/preview/2017-03-01-preview/longTermRetention.json

@@ -317,7 +317,7 @@
              "Deleted"
            ],
            "x-ms-enum": {
-              "name": "databaseState",
+              "name": "longTermRetentionDatabaseState",


While we're at it consider creating a common definition for this parameter in the parameters/definitions section thus avoiding duplication

We have swagger generator so for now it's easier to keep it duplicated rather than manually edit :)

AutorestCI · 2018-03-19T17:14:01Z

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#1335

jaredmoo · 2018-03-19T17:15:38Z

...ication/sql/resource-manager/Microsoft.Sql/preview/2017-03-01-preview/longTermRetention.json

@@ -317,7 +317,7 @@
              "Deleted"
            ],
            "x-ms-enum": {
-              "name": "databaseState",
+              "name": "longTermRetentionDatabaseState",


We have swagger generator so for now it's easier to keep it duplicated rather than manually edit :)

…Parameter

dsgouda

LGTM

trgrie and others added 27 commits January 11, 2018 11:02

Remove empty properties and update retention description

c3e1246

This update is a response to the few comments that Anu left on the PR. It removes an empty properties entry and updates the retention descriptions to explain that they use an ISO 8601 standard.

Description and Entity Name Changes

6a46b46

Made some slight changes to the entity names to better align with LTR V1 and added some better descriptors to some property descriptions.

Fixing Incorrect Description

71a7183

The weekOfYear parameter is not in an ISO 8601 format, it is just an integer between 1 and 52. Fixing that accordingly.

Remove Conflicting Definitions

1ef82da

Need to remove backupLongTermRetentionPolicies so it doesn't conflict with the new backupLongTermRetentionPolicies.

Remove Reference to backupLongTermRetentionPolicies.json

a45f1c2

Need to remove the reference to backupLongTermRetentionPolicies.json in the readme.

Update ResourceId

7aff182

Updated the resource ID for longTermRetentionBackups so servers and databases are now longTermRetentionServers and longTermRetentionDatabases, respectively. This better aligns with REST.

Re-Adding LongTermRetentionPolicyGet.json

9e10fc2

LongTermRetentionPolicyGet.json was accidentally deleted in the last commit.

Merge branch 'master' into master

83aeda2

Fix Travis CI Errors

5cbcc1f

Made some changes to the examples to fix the Travis CI errors.

Pulling Jared's readme.md changes and updating LongTermRetentionPolic…

edaa127

…ies to BackupLongTermRetentionPolicies

Updating more references to BackupLongTermRetentionPolic(y|ies)

c3aa875

Re-adding backupLongTermRetentionPolicies.json

b98cf6c

removing .travis.yml that was accidentally added

3b80fa0

Revert "removing .travis.yml that was accidentally added"

2bbc4d5

This reverts commit 3b80fa0.

Revert "Re-adding backupLongTermRetentionPolicies.json"

185575d

This reverts commit b98cf6c.

undoing accidental .travis.yml

3e1bb26

Merge branch 'master' into master

66816de

Fixing errors in model PR_ONLY=true Travis CI run

1589bf2

Merge branch 'master' of https://github.com/trgrie/azure-rest-api-specs

befb809

Fixing another Travis CI error

36eb124

Removing .travis.yml from the change and changing LongTermRetentionPo…

0f0a1a7

…licy to BackupLongTermRetentionPolicy to keep it consistent

resetting backupLongTermRetentionPolicies.json

20cac86

Update more references of LongTermRetentionPolicy to BackupLongTermRe…

68173d9

…tentionPolicy

updating readme.md comment

804026b

Merge remote-tracking branch 'upstream/master'

d9f8bd4

updating databaseState to longTermRetentionDatabaseState

922cc7b

trgrie requested a review from a user March 19, 2018 17:05

trgrie requested review from tiffanyachen and vladbarosan as code owners March 19, 2018 17:05

azuresdkci assigned dsgouda Mar 19, 2018

AutorestCI mentioned this pull request Mar 19, 2018

[AutoPR sql/resource-manager] Change databaseState in longTermRetention.json to longTermRetentionDatabaseState Azure/azure-sdk-for-python#2215

Merged

AutorestCI mentioned this pull request Mar 19, 2018

[AutoPR sql/resource-manager] Change databaseState in longTermRetention.json to longTermRetentionDatabaseState Azure/azure-libraries-for-java#328

Merged

dsgouda reviewed Mar 19, 2018

View reviewed changes

AutorestCI mentioned this pull request Mar 19, 2018

[AutoPR sql/resource-manager] Change databaseState in longTermRetention.json to longTermRetentionDatabaseState Azure/azure-sdk-for-go#1331

Merged

jaredmoo approved these changes Mar 19, 2018

View reviewed changes

trgrie added 2 commits March 19, 2018 10:19

Making longTermRetentionDatabaseState a common parameter

58d3850

adding parameter location as method to LongTermRetentionDatabaseState…

de2f644

…Parameter

dsgouda approved these changes Mar 19, 2018

View reviewed changes

dsgouda merged commit 9bcba95 into Azure:master Mar 19, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change databaseState in longTermRetention.json to longTermRetentionDatabaseState #2693

Change databaseState in longTermRetention.json to longTermRetentionDatabaseState #2693

trgrie commented Mar 19, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Mar 19, 2018 •

edited

Loading

AutorestCI commented Mar 19, 2018 •

edited

Loading

AutorestCI commented Mar 19, 2018 •

edited

Loading

dsgouda Mar 19, 2018

jaredmoo Mar 19, 2018

AutorestCI commented Mar 19, 2018 •

edited

Loading

jaredmoo Mar 19, 2018

dsgouda left a comment

Change databaseState in longTermRetention.json to longTermRetentionDatabaseState #2693

Change databaseState in longTermRetention.json to longTermRetentionDatabaseState #2693

Conversation

trgrie commented Mar 19, 2018 • edited by azuresdkci Loading

PR information

Quality of Swagger

AutorestCI commented Mar 19, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Mar 19, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Mar 19, 2018 • edited Loading

Automation for azure-libraries-for-java

dsgouda Mar 19, 2018

Choose a reason for hiding this comment

jaredmoo Mar 19, 2018

Choose a reason for hiding this comment

AutorestCI commented Mar 19, 2018 • edited Loading

Automation for azure-sdk-for-go

jaredmoo Mar 19, 2018

Choose a reason for hiding this comment

dsgouda left a comment

Choose a reason for hiding this comment

trgrie commented Mar 19, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Mar 19, 2018 •

edited

Loading

AutorestCI commented Mar 19, 2018 •

edited

Loading

AutorestCI commented Mar 19, 2018 •

edited

Loading

AutorestCI commented Mar 19, 2018 •

edited

Loading